Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZDC Phase2 HcalTPChannelParameters update to silence multiple warnings #46721

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

abdoulline
Copy link

@abdoulline abdoulline commented Nov 18, 2024

PR description:

Complementary to Sunanda's just submitted #46720
Silences 18 warnings at beginRun mentioned earlier by @mmusich

PR validation:

wf 29634.0 runs without warnings

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2024

cms-bot internal usage

@abdoulline abdoulline changed the title ZDC Phase2 HcalTPChannelParameters update to silence the warnings ZDC Phase2 HcalTPChannelParameters update to silence multiple warnings Nov 18, 2024
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abdoulline for master.

It involves the following packages:

  • CalibCalorimetry/HcalAlgos (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@bsunanda, @mariadalfonso, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f9d62/42919/summary.html
COMMIT: f7d5f83
CMSSW: CMSSW_14_2_X_2024-11-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46721/42919/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

Expand to see more relval errors ...

@perrotta
Copy link
Contributor

@smuzaffar I can't see the link to the "Comparisons failed" in these latest PR tests: is it due to the failing RelVals in those tests? Even if the errors are evidently unrelated DAS errors, as in this case? See also #46719 (comment)

@smuzaffar
Copy link
Contributor

yes @perrotta when there are relval errors then bot does not run comparison job

@perrotta
Copy link
Contributor

please test
(let retry, then)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f9d62/42937/summary.html
COMMIT: f7d5f83
CMSSW: CMSSW_14_2_X_2024-11-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46721/42937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4a55338 into cms-sw:master Nov 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants