-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZDC Phase2 HcalTPChannelParameters update to silence multiple warnings #46721
ZDC Phase2 HcalTPChannelParameters update to silence multiple warnings #46721
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46721/42691 |
A new Pull Request was created by @abdoulline for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals RelVals
Expand to see more relval errors ...
|
@smuzaffar I can't see the link to the "Comparisons failed" in these latest PR tests: is it due to the failing RelVals in those tests? Even if the errors are evidently unrelated DAS errors, as in this case? See also #46719 (comment) |
yes @perrotta when there are relval errors then bot does not run comparison job |
please test |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Complementary to Sunanda's just submitted #46720
Silences 18 warnings at beginRun mentioned earlier by @mmusich
PR validation:
wf 29634.0 runs without warnings